Skip to content

fix(deploy): validate target boot layout - #260

Open
mchave3 wants to merge 1 commit into
mainfrom
fix/deploy-layout-validation
Open

fix(deploy): validate target boot layout#260
mchave3 wants to merge 1 commit into
mainfrom
fix/deploy-layout-validation

Conversation

@mchave3

@mchave3 mchave3 commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Validate the actual target disk layout after DiskPart and the required inputs immediately before BCDBoot.

Reason

A successful DiskPart exit code did not prove that the target ESP and Windows volumes were usable, and BCDBoot failures lacked prerequisite-specific diagnostics.

Main changes

  • increase the ESP from 260 MiB to 300 MiB
  • refresh and retry WinPE Storage discovery for up to 30 seconds after DiskPart
  • verify GPT, same-disk partition ownership, EFI GPT type, FAT32, assigned letter, ESP size, and NTFS Windows/recovery volumes
  • verify BCDBoot, BCD-Template, ESP accessibility, and ESP writability before execution
  • localize all new validation and failure messages in all 38 supported cultures
  • add regression coverage for retry behavior, invalid GPT/ESP/JSON, missing boot prerequisites, and localization presence

Testing

  • x64 Foundry.Deploy.Tests: 379 passed
  • ARM64 Foundry.Deploy build: passed
  • repository format verification: passed

Merge order

Merge PR #259 first, then synchronize this branch with main before merging because both PRs extend the localization resources.

Copilot AI review requested due to automatic review settings July 30, 2026 14:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added tests Test coverage or test infrastructure change project: foundry-deploy Changes in the Foundry.Deploy deployment application labels Jul 30, 2026
@mchave3 mchave3 self-assigned this Jul 30, 2026
@mchave3 mchave3 moved this from New to In Progress in Foundry OSD Development Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: foundry-deploy Changes in the Foundry.Deploy deployment application tests Test coverage or test infrastructure change

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants