Skip to content

fix: scope /i flag to keywords only — prevent lowercase false-positives #35 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
four-bytes-robby merged 1 commit into from
Jun 12, 2026
Merged

fix: scope /i flag to keywords only — prevent lowercase false-positives #35 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/detectors/regex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const RULES: RegexRule[] = [
// ── Reference Number (keyword-triggered) ───────────────
{
type: "reference",
pattern: /\b(?:Referenz|Ref\.|Kunden(?:-?nummer)?|Kd\.-Nr\.|Vorgangs(?:-?nummer)?|Rechnungs(?:-?nummer)?|RG\.-Nr\.|Auftrags(?:-?nummer)?|Beleg(?:-?nummer)?|Ticket(?:-?nummer)?|Fall(?:-?nummer)?)\b\s*[:#]?\s*([A-Z0-9][\-A-Z0-9\/]{2,40})\b/gi,
pattern: /\b(?i:Referenz|Ref\.|Kunden(?:-?nummer)?|Kd\.-Nr\.|Vorgangs(?:-?nummer)?|Rechnungs(?:-?nummer)?|RG\.-Nr\.|Auftrags(?:-?nummer)?|Beleg(?:-?nummer)?|Ticket(?:-?nummer)?|Fall(?:-?nummer)?)\b\s*[:#]?\s*([A-Z0-9][\-A-Z0-9\/]{2,40})\b/g,
label: "REFERENCE",
priority: 8,
},
Expand Down
16 changes: 16 additions & 0 deletions test/regex-detector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,4 +237,20 @@ describe("RegexDetector", () => {
expect(emails[0].replacement).toBe("<EMAIL_1>");
expect(emails[1].replacement).toBe("<EMAIL_2>");
});

// ── English/Tech Word False-Positive Regression (#35)
it("does NOT detect common English/tech words as PII", () => {
const safeWords = [
"ticket", "chat", "teams", "fallback", "reference",
"account", "key", "case", "id", "session", "message", "token",
];
for (const word of safeWords) {
const matches = detector.detect(
`The ${word} was processed successfully.`
);
if (matches.length > 0) {
throw new Error(`Word "${word}" was falsely detected as PII: ${matches[0].type} (${matches[0].match})`);
}
}
});
});
Loading