fix: rewrite port file when session ID becomes available#142
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review WalkthroughWalkthroughIn ChangesSession-scoped port discovery file persistence
Estimated code review effort3 (Moderate) | ~15 minutes Possibly related PRs
Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Tip: You can configure your own custom pre-merge checks in the settings. Finishing TouchesGenerate docstrings
Generate unit tests (beta)
Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port file now updated with session-scoped hash when setSessionId is called.
Summary by cubic
Rewrite the status port file when a session ID is set, scoping it per session so clients reliably discover the correct port and avoid collisions. We hash the session ID to generate status-port-.json under ~/.cache/opencode/brain, write { port } only if a port is set, and create the directory if missing.
Written for commit d636098. Summary will update on new commits.
Summary by CodeRabbit