fix: spawn lock + dead port reconnect#12
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review WalkthroughWalkthroughTwo bus connection fixes are applied: ChangesBus connection robustness
Estimated code review effort3 (Moderate) | ~20 minutes Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Tip: You can configure your own custom pre-merge checks in the settings. Finishing TouchesGenerate docstrings
Generate unit tests (beta)
Simplify code
Comment |
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds spawn lock to prevent duplicate bus binaries. scheduleReconnect now re-reads port file before retry.
Summary by cubic
Prevents duplicate bus processes during concurrent connects and fixes reconnects when the bus restarts on a new port.
Written for commit b96489a. Summary will update on new commits.
Summary by CodeRabbit