Skip to content

fix: align @typescript-eslint packages to 8.61.0#24

Merged
four-bytes-robby merged 1 commit into
mainfrom
fix/23-typescript-eslint-skew
Jun 14, 2026
Merged

fix: align @typescript-eslint packages to 8.61.0#24
four-bytes-robby merged 1 commit into
mainfrom
fix/23-typescript-eslint-skew

Conversation

@four-bytes-robby

@four-bytes-robby four-bytes-robby commented Jun 14, 2026

Copy link
Copy Markdown
Member

Description

CodeRabbit found on merged PR #7: @typescript-eslint/eslint-plugin was at 8.47.0 but @typescript-eslint/parser was at 8.61.0 — version skew causing unpredictable lint behavior.

Changes

  • Bumped @typescript-eslint/eslint-plugin from 8.47.0 → 8.61.0
  • Bumped typescript-eslint from ^8.47.0 → ^8.61.0 for consistency
  • Fixed new lint violations introduced by 8.61.0 rules:
    • no-useless-assignment in diff-parse.ts — removed unused initializers
    • preserve-caught-error in gh-utils.ts and git-utils.ts — added { cause: err } to re-thrown errors

Verification

  • bun install — lockfile updated
  • bun run lint — 0 errors (3 pre-existing warnings only)
  • bun run typecheck — passes
  • bun test — 145 pass, 0 fail

Closes #23


Summary by cubic

Align all @typescript-eslint packages to 8.61.0 to remove version skew and stabilize linting. Also update eslint deps for compatibility and fix new rule violations.

  • Dependencies

    • Align @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and typescript-eslint to 8.61.0.
    • Update eslint and @eslint/js to 10.x for compatibility.
  • Bug Fixes

    • Remove useless initializers in src/lib/diff-parse.ts (rule: no-useless-assignment).
    • Preserve error causes in rethrows in src/lib/gh-utils.ts and src/lib/git-utils.ts (rule: preserve-caught-error).

Written for commit 4639ae0. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores

    • Updated development dependencies including linting and type-checking tools to their latest available versions to maintain modern code quality standards
  • Refactor

    • Improved error handling and diagnostic capabilities across multiple utility functions to better preserve and communicate underlying error information when system operations fail, enabling more effective troubleshooting and debugging

@four-bytes-robby four-bytes-robby merged commit 435ba7d into main Jun 14, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

Recent review info
Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a708b9e-aab6-4c6d-995a-737f69a88b83

Commits

Reviewing files that changed from the base of the PR and between bc39ccb and 4639ae0.

Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
Files selected for processing (4)
  • package.json
  • src/lib/diff-parse.ts
  • src/lib/gh-utils.ts
  • src/lib/git-utils.ts

Walkthrough

Walkthrough

Bumps @eslint/js to ^10.0.1 and typescript-eslint to ^8.61.0 in package.json. Applies the resulting lint fixes: runGit, runGh, and resolveRepo now attach { cause: err } when re-throwing errors, and parseUnifiedDiff removes redundant = 0 initializers from four internal counter variables.

Changes

ESLint/typescript-eslint upgrade and lint compliance fixes

Layer / File(s) Summary
devDependency version bumps
package.json
@eslint/js bumped from ^9.39.1 to ^10.0.1; typescript-eslint bumped from ^8.47.0 to ^8.61.0.
Error cause chaining and uninitialized variable fixes
src/lib/git-utils.ts, src/lib/gh-utils.ts, src/lib/diff-parse.ts
runGit, runGh, and resolveRepo now pass { cause: err } when constructing re-thrown errors. parseUnifiedDiff drops the redundant = 0 initializers from oldLine, newLine, oldCount, and newCount.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

dependencies, javascript

Finishing Touches
Generate docstrings
  • Create stacked PR
  • Commit on current branch
Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/23-typescript-eslint-skew
Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/23-typescript-eslint-skew

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Comment @coderabbitai help to get the list of available commands and usage tips.

@four-bytes-robby four-bytes-robby deleted the fix/23-typescript-eslint-skew branch June 14, 2026 21:58
@coderabbitai coderabbitai Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 14, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: align @typescript-eslint packages to 8.61.0

1 participant