fix: align @typescript-eslint packages to 8.61.0#24
Conversation
|
Caution Review failedThe pull request is closed. Recent review infoRun configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Files ignored due to path filters (1)
Files selected for processing (4)
WalkthroughWalkthroughBumps ChangesESLint/typescript-eslint upgrade and lint compliance fixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Finishing TouchesGenerate docstrings
Generate unit tests (beta)
Simplify code
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Comment |
Description
CodeRabbit found on merged PR #7:
@typescript-eslint/eslint-pluginwas at 8.47.0 but@typescript-eslint/parserwas at 8.61.0 — version skew causing unpredictable lint behavior.Changes
@typescript-eslint/eslint-pluginfrom 8.47.0 → 8.61.0typescript-eslintfrom ^8.47.0 → ^8.61.0 for consistencyno-useless-assignmentindiff-parse.ts— removed unused initializerspreserve-caught-erroringh-utils.tsandgit-utils.ts— added{ cause: err }to re-thrown errorsVerification
bun install— lockfile updatedbun run lint— 0 errors (3 pre-existing warnings only)bun run typecheck— passesbun test— 145 pass, 0 failCloses #23
Summary by cubic
Align all
@typescript-eslintpackages to 8.61.0 to remove version skew and stabilize linting. Also updateeslintdeps for compatibility and fix new rule violations.Dependencies
@typescript-eslint/eslint-plugin,@typescript-eslint/parser, andtypescript-eslintto 8.61.0.eslintand@eslint/jsto 10.x for compatibility.Bug Fixes
src/lib/diff-parse.ts(rule:no-useless-assignment).src/lib/gh-utils.tsandsrc/lib/git-utils.ts(rule:preserve-caught-error).Written for commit 4639ae0. Summary will update on new commits.
Summary by CodeRabbit
Chores
Refactor