chore(deps-dev): bump @eslint/js from 9.39.4 to 10.0.1#5
chore(deps-dev): bump @eslint/js from 9.39.4 to 10.0.1#5dependabot[bot] wants to merge 1 commit into
Conversation
|
@dependabot rebase |
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.39.4 to 10.0.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](https://github.com/eslint/eslint/commits/v10.0.1/packages/js) --- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 10.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
8933372 to
a57f6f7
Compare
WalkthroughWalkthroughThe ChangesDependency Version Update
Estimated code review effort🎯 1 (Trivial) | ~2 minutes Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Tip: You can configure your own custom pre-merge checks in the settings. Finishing TouchesGenerate unit tests (beta)
Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 35: The `@eslint/js` dependency at version 10.0.1 requires eslint ^10.0.0
as a peer dependency, but the eslint entry in package.json (line 40) is
currently pinned to ^9.39.1, creating a version mismatch. Update the eslint
dependency from ^9.39.1 to ^10.0.0 or higher within the 10.x major version to
satisfy the peer dependency requirement and ensure compatibility with `@eslint/js`
10.0.1.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "^9.39.1", | ||
| "@eslint/js": "^10.0.1", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for Node.js version declarations
echo "Checking for Node.js version declarations..."
if [ -f .node-version ]; then
echo "Found .node-version:"
cat .node-version
fi
if [ -f .nvmrc ]; then
echo "Found .nvmrc:"
cat .nvmrc
fi
if [ -f .tool-versions ]; then
echo "Found .tool-versions:"
grep nodejs .tool-versions
fi
# Check for engines field in package.json
echo ""
echo "Checking package.json engines field:"
jq '.engines' package.json
# Check CI config for Node version
echo ""
echo "Checking GitHub Actions workflows for Node.js version:"
fd -t f -e yml -e yaml .github/workflows | head -5 | xargs grep -h "node-version" 2>/dev/null || echo "No CI config found"Repository: four-bytes/four-opencode-supertools
Length of output: 634
🏁 Script executed:
# Correct the CI workflow check
fd --full-path '.github/workflows' . | xargs grep -l "node-version" 2>/dev/null || echo "No workflows with node-version found"Repository: four-bytes/four-opencode-supertools
Length of output: 116
🏁 Script executed:
# Also check for Dockerfile and other potential Node.js version declarations
find . -maxdepth 2 -type f \( -name "Dockerfile*" -o -name "docker-compose*" -o -name ".eslintrc*" -o -name "eslint.config.*" \) | head -20Repository: four-bytes/four-opencode-supertools
Length of output: 98
🌐 Web query:
@eslint/js 10.0.1 npm peer dependencies eslint version requirement
💡 Result:
The @eslint/js package version 10.0.1 defines its peer dependency requirement for ESLint as ^10.0.0 [1]. Additionally, this peer dependency is marked as optional via peerDependenciesMeta [1].
Citations:
🏁 Script executed:
# Check package.json for any other potential Node.js hints
cat -n package.json | head -50Repository: four-bytes/four-opencode-supertools
Length of output: 1735
🏁 Script executed:
# Check if there's any documentation about Node.js requirements
find . -maxdepth 2 -type f \( -name "README*" -o -name "*.md" \) | xargs grep -i "node" 2>/dev/null | head -10Repository: four-bytes/four-opencode-supertools
Length of output: 146
Bump eslint to version ^10.0.0 to match @eslint/js 10.0.1 peer dependency.
The @eslint/js 10.0.1 package requires eslint ^10.0.0 as a peer dependency, but the project currently specifies eslint ^9.39.1 (line 40). This version mismatch will cause installation or runtime failures. Update eslint to a compatible version in the same major release as @eslint/js.
Note: @eslint/js 10.0.0 also requires Node.js ^20.19.0 || ^22.13.0 || >=24. The project does not declare an engines field or other Node.js version constraints, so verify that your target environment meets this requirement.
Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 35, The `@eslint/js` dependency at version 10.0.1
requires eslint ^10.0.0 as a peer dependency, but the eslint entry in
package.json (line 40) is currently pinned to ^9.39.1, creating a version
mismatch. Update the eslint dependency from ^9.39.1 to ^10.0.0 or higher within
the 10.x major version to satisfy the peer dependency requirement and ensure
compatibility with `@eslint/js` 10.0.1.
|
Coderabbit approved this (1-dart review, all pre-merge checks passed), but the check CI step fails because @eslint/js@^10.0.1 is incompatible with the existing eslint@^9.39.1 peer dependency. Bumping eslint to v10 alongside this would be a breaking change requiring wider testing. Closing — feel free to reopen with a combined eslint+@eslint/js bump. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
@coderabbitai Good catch on the peer-dep mismatch. We closed this PR because bumping only Will handle both together in a follow-up: |
|
Tip For best results, initiate chat on the files or code changes.
Would you like me to open a follow-up GitHub issue to track the coordinated bump ( ✏️ Learnings added
|
Bumps @eslint/js from 9.39.4 to 10.0.1.
Release notes
Sourced from @eslint/js's releases.
... (truncated)
Commits
84fb885chore: package.json update for@eslint/jsrelease1f66734chore: addeslinttopeerDependenciesof@eslint/js(#20467)f3fbc2fchore: set@eslint/jsversion to 10.0.0 to skip releasing it (#20466)b4b3127chore: package.json update for@eslint/jsrelease0b14059chore: package.json update for@eslint/jsreleasefa31a60feat!: addnameto configs (#20015)1e2cad5chore: package.json update for@eslint/jsrelease454a292feat!: updateeslint:recommendedconfiguration (#20210)c6358c3feat!: Require Node.js^20.19.0 || ^22.13.0 || >=24(#20160)Summary by CodeRabbit