Include abstract classes in the hierarchy with forwards on it - #498
Merged
Conversation
evandongen
commented
Jul 17, 2026
| if(parent != null) { | ||
| elem -> elem.getAttributes(ElementChild.JSON_RELEVANT).isEmpty() | ||
| && elem.getConfigChildren(ElementChild.JSON_RELEVANT).isEmpty() | ||
| && elem.getForwards().isEmpty()); |
Contributor
Author
There was a problem hiding this comment.
This is what did the trick
Member
There was a problem hiding this comment.
What about parameters?
Will elements with inherited parameters now be skipped again?
Contributor
Author
There was a problem hiding this comment.
I don't see how this relates to parameters?
Contributor
Author
There was a problem hiding this comment.
So much user specific files in the codebase, added some to the ignore files.
evandongen
changed the title
Matthbo
reviewed
Jul 17, 2026
Matthbo
left a comment
Matthbo
left a comment
Member
There was a problem hiding this comment.
I'm missing some a test to prove that it works as intended
| if(parent != null) { | ||
| elem -> elem.getAttributes(ElementChild.JSON_RELEVANT).isEmpty() | ||
| && elem.getConfigChildren(ElementChild.JSON_RELEVANT).isEmpty() | ||
| && elem.getForwards().isEmpty()); |
Member
There was a problem hiding this comment.
What about parameters?
Will elements with inherited parameters now be skipped again?
Updated pnpm version and Node.js setup in workflow.
Contributor
Author
Fair enough, I'll add a test! |
…-include' into feature/fixedforwardpipe-forward-include
Matthbo
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, not the clean up I wanted, but I think this is what we need. The forward is actually added in the
Base64Pipepage, and in the hierarchy theFixedForwardPipeis now the parent.I've built this, ran a frankframework build with
attachFrankDocand used that JSON to run the doc frontend to double check this. Looks pretty good up until now.