Enforce execution order using mutexes - #242
Open
jupenur wants to merge 6 commits into
Open
Conversation
jupenur
marked this pull request as draft
August 27, 2026 10:52
jupenur
marked this pull request as ready for review
August 27, 2026 11:23
Member
Author
|
This is probably easiest to review one commit at a time. Each commit pretty much fixes one issue. I could've opened separate PRs for each one but this way there's less to merge. |
Member
|
Hey, sorry for the delay here! I didn't have the continuous time needed to followup and understand, but will ensure do so by this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223:
updatelistener is no longer responsible for clearing caches; caches are cleared inWebcatRequestHandler.bind, where a mutex ensures execution does not interleave with#onRequest.NamespacedKVStoreoperations ensures they cannot interleave with operations of the same instance. No guarantees are provided across instances.WebcatDatabase.updateListno longer callsenrollments.clearEnrollmentUpdater.retryIfFailedcalls only callupdateonce if the update succeeds.