π‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in background workers - #89
π‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in background workers#89frkr wants to merge 4 commits into
Conversation
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: Dynamic URLs retrieved from R2 object contents and accessed by the background worker in
src/mq/MQDestiny.tsandsrc/mq/MQCallback.tsduringfetch()calls did not have their protocol validated.π― Impact: If an attacker can control the destination or callback URLs configured for background processing, they could force the worker to access arbitrary network schemes (e.g.,
file:, internal APIs, data URIs), resulting in a potential Server-Side Request Forgery (SSRF). Unhandled URL parsing failures would also trigger infinite background queue retry loops.π§ Fix: Wrapped the URL parsing in a
try...catchblock usingnew URL()and explicitly enforced that the resolvedprotocolmust be eitherhttp:orhttps:. Invalid URLs now fail safely and route to an error state usingMQStorerather than continually retrying. Documented this mitigation strategy in.jules/sentinel.md.β Verification: Verified by running
pnpm testwhich includes new tests validating SSRF protection in both modules.PR created automatically by Jules for task 13490444322795653780 started by @frkr