Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in background workers - #89

Open
frkr wants to merge 4 commits into
mainfrom
sentinel/fix-ssrf-background-workers-13490444322795653780
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in background workers#89
frkr wants to merge 4 commits into
mainfrom
sentinel/fix-ssrf-background-workers-13490444322795653780

Conversation

@frkr

@frkr frkr commented Aug 13, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Dynamic URLs retrieved from R2 object contents and accessed by the background worker in src/mq/MQDestiny.ts and src/mq/MQCallback.ts during fetch() calls did not have their protocol validated.
🎯 Impact: If an attacker can control the destination or callback URLs configured for background processing, they could force the worker to access arbitrary network schemes (e.g., file:, internal APIs, data URIs), resulting in a potential Server-Side Request Forgery (SSRF). Unhandled URL parsing failures would also trigger infinite background queue retry loops.
πŸ”§ Fix: Wrapped the URL parsing in a try...catch block using new URL() and explicitly enforced that the resolved protocol must be either http: or https:. Invalid URLs now fail safely and route to an error state using MQStore rather than continually retrying. Documented this mitigation strategy in .jules/sentinel.md.
βœ… Verification: Verified by running pnpm test which includes new tests validating SSRF protection in both modules.


PR created automatically by Jules for task 13490444322795653780 started by @frkr

Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 3 commits August 13, 2026 08:29
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant