bch: bootstrap src/impl/bch skeleton (M2)#61
Merged
Conversation
Mirror src/impl/btc layout. Stub coin/ + daemon/ + test/ slices. - config_coin.hpp: CashAddr scaffolding, HogEx out-of-scope note - coin/header_chain.hpp: ASERT insertion point (BCH-specific slice 1/2) - coin/template_builder.hpp: CTOR insertion point (slice 2/2), CashTokens note - CMakeLists: -DCOIN_BCH=ON gate (per-coin binary scheme) Per impl plan c2pool-bch-embedded-impl-plan.md v36.
frstrtr
force-pushed
the
bch/bootstrap-skeleton
branch
from
d3b346e to
79928c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2: bootstrap src/impl/bch skeleton
Bootstraps the BCH (Bitcoin Cash) V36 coin module skeleton. Implements M2 of the c2pool-bch-embedded-impl-plan (frstrtr/the docs, master d6ee6f0). Companion to dgb #60 / per-coin binary scheme.
Shape
Inert-guard skeleton, matching the dgb #60 precedent exactly:
src/impl/bch/CMakeLists.txt:if(COIN_BCH)guard,message(STATUS ...), sub-add_subdirectory/add_libraryleft as commented TODO(M3).-DCOIN_BCH=ON; emits thec2pool-bchbinary at M3.src/impl/btc/layout:coin/(header_chain, template_builder stubs),daemon/,test/,config_coin.hpp.Registration / OBJECT-lib convention
Per dgb #60, the active
add_library(impl_bch OBJECT ...)and the top-leveladd_subdirectory(src/impl/bch)registration are the OBJECT-lib convention PR (ci-steward owns), deliberately not raced into the bootstrap. No LINK_GROUP (supersedes the earlier #54 LINK_GROUP approach). This PR therefore configures cleanly as a no-op: the module is present in-tree but not yet wired into the build graph — identical to dgb at #60.If ci-steward wants the active top-level
add_subdirectory+add_library(impl_bch OBJECT)to land in this PR (bch as the convention first-mover rather than waiting on the convention PR), I can amend within a heartbeat — flagging on the task thread.Scope / safety
src/impl/btc/orbitcoin_family/changes.Diff: 6 files, +64.