Honor caller-owned outfile in get_file - #2066
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Allow outfile to replace lpath, preserve an explicitly supplied outfile when lpath is file-like, and only close streams opened internally. Add regression coverage for both outfile-only and precedence behavior. Fixes fsspec#1841
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_file(..., outfile=stream)currently still requires and prepareslpath, then closes the caller-owned stream; when both are file-like,lpathalso silently replaces the explicitoutfile. This letsoutfilestand in forlpath, gives the explicit argument precedence, and only closes streams opened by fsspec. Fixes #1841.