upgrade messages_ja.json - #3
Draft
Martsings wants to merge 15 commits into
Draft
Conversation
Fix the URL of kustomize
Update Dev docs
Revert "Update Dev docs"
kobaji
marked this pull request as draft
October 22, 2020 01:18
kobaji
reviewed
Oct 22, 2020
kobaji
left a comment
kobaji
left a comment
Member
There was a problem hiding this comment.
リソースの種類(Namespace, Task等)は、大文字始まりで統一した方が良いと思いました。英語が小文字始まりだとしても。
確かに日本語の表記で普通大文字始まりですね。こちらは修正します。
→修正を確認しました。この点に関して追加指摘はありません。
今後コミットが発生した場合、必要に応じて差分の英単語も確認するようにします。
kobaji
requested changes
Oct 26, 2020
kobaji
requested changes
Oct 26, 2020
yamaken1343
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
reviewed
Oct 27, 2020
kobaji
requested changes
Oct 27, 2020
Member
|
本日のWebUIによるレビュー時、小林のAIになっていたものです。 作業履歴
|
kobaji
reviewed
Oct 27, 2020
yamaken1343
self-requested a review
October 29, 2020 01:35
kobaji
reviewed
Oct 29, 2020
kobaji
reviewed
Oct 29, 2020
Member
|
すべてResolveしました。作成、修正お疲れ様でした！ |
load messages_ja.json file to translations file branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
upgarde messages_ja.json