test: capture five table views for visual regression - #64
Merged
Conversation
Adds a Chromatic spec over the default, filtered, dark, right-to-left and empty views, plus the npm script that uploads what the sweep archives. Lint now ignores test-results, where the archived page resources land. The first run needs a project token and is not wired into CI.
Runs last in the verify job, over the archives the sweep already wrote. A visual change exits zero, so the accept gate is Chromatic's own pull request check rather than a red build. The step is skipped when no token is present, which is every fork pull request.
Bundle ReportBundle size has no change ✅ |
funkadelic
marked this pull request as ready for review
September 2, 2026 22:51
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 565 565
Branches 100 100
=========================================
Hits 565 565 ☔ View full report in Codecov by Harness. |
funkadelic
force-pushed
the
test/chromatic-visual-snapshots
branch
from
September 2, 2026 22:55
158255c to
63681c3
Compare
Both event types reached the step, in different concurrency groups, so every commit was captured and metered twice. The upload no longer waits out the capture, and the token now sits on the one step that needs it rather than in the environment of all twenty.
On a pull request the checkout is a merge ref, so the CLI filed each build against a commit that exists in no branch and is later collected, losing the author, the date and the pull request status link. The action reads the head commit off the event payload instead.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds visual regression testing over five views of the table: the default list, a searched and sorted page, dark theme, right to left, and an empty result.