feat: add Chinese variant conversion via OpenCC#52
Open
fzlins wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add automatic Chinese variant conversion (Simplified ↔ Traditional) applied after extraction, before saving
metadata.jsonandimport.csv.Changes
requirements.txt— Addopencc-python-reimplemented>=0.1.7(pure Python, no C++ build required)config.ini— Addchinese_convertoptiontmdb-import/util/chinese_convert.py(new) — Conversion module with lazy-singleton OpenCC converter and punctuation tablestmdb-import/extractor.py— Hook conversion into pipeline;extract_from_urlnow returnsmetadataREADME.md/docs/README.zh-CN.md— Document new config optionConfiguration
How it works
Metadataobject, checksmetadata.languagelanguagestarts withzh(coverszh-CN,zh-TW,zh-HK,zh-SG, etc.) andchinese_convertis set, runs conversion in-placemetadata.jsonandimport.csvare saved with the converted textOpenCC config mapping:
zh-CNt2szh-TWs2twpzh-HKs2hkPunctuation conversion (handled separately since OpenCC doesn't convert punctuation by default):
zh-CN「」『』→""''zh-TW/zh-HK""''→「」『』