Conversation
mcilloni
reviewed
Aug 7, 2026
| ]; | ||
|
|
||
| info!( | ||
| "Executing: {} {:?} > {}", |
There was a problem hiding this comment.
The real risk I see in this approach is that if your checkpoint is bigger than the free space, you risk locking up the server.
Comment on lines
+171
to
+173
| String::from("send"), | ||
| String::from("-R"), | ||
| String::from("-v"), |
There was a problem hiding this comment.
note that this will almost definitely not work with encrypted datasets - or, rather, the send will work but it will send the stuff unencrypted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the support for creating zfs snapshots, send them to file, and treat this as a
Service- so we can uplaod them to aRemote.