Skip to content

fix compressed-diff workflow #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bfintal wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

fix compressed-diff workflow #3589

Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0ee2bd0
fix compressed-diff workflow
Sep 10, 2025
b22aecd
try adding legacy peer deps
Sep 10, 2025
09ee926
try doing build:no-translate
Sep 10, 2025
8a4bb86
try removing premium
Sep 10, 2025
578558d
try using pre-built files
Sep 10, 2025
cd83e62
try build true
Sep 10, 2025
1a6704d
try different approach
Sep 10, 2025
efb3052
try new size comparison
Sep 10, 2025
a740f0e
try checkout
Sep 10, 2025
71acb10
try another path
Sep 10, 2025
9b93e2d
added comparisons
Sep 10, 2025
061a4e9
test changes
Sep 10, 2025
61a69d0
updated filename
Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions .github/workflows/compressed-diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,31 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v2 # Checkout the Stackable Premium repo.
- uses: actions/checkout@v4
- uses: actions/checkout@v4 # Checkout the Stackable Premium repo.
with:
repository: 'bfintal/Stackable-Premium'
ref: 'v3'
path: 'pro__premium_only'
token: '${{ secrets.ACCESS_KEY }}'
- name: Install Composer Dependencies
run: |
composer install --prefer-dist --no-progress --ignore-platform-reqs
- name: Setup Node # Fix because we can't do npm ci --legacy-peer-deps
uses: actions/setup-node@v1
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: '3.9'
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Upgrade setup-python to v5 (v4 now blocked on GH runners).

actionlint indicates v4 can’t run; bump the action version.

-    - name: Setup Python
-      uses: actions/setup-python@v4
+    - name: Setup Python
+      uses: actions/setup-python@v5
       with:
         python-version: '3.9'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: '3.9'
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.9'
🧰 Tools
🪛 actionlint (1.7.7)

20-20: the runner of "actions/setup-python@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents 
.github/workflows/compressed-diff.yml around lines 19 to 22: the workflow uses
actions/setup-python@v4 which is blocked on GH runners; update the action
reference to actions/setup-python@v5, keep the same inputs (python-version:
'3.9') and commit the change, then trigger or run the workflow to verify the
updated action works as expected.

- name: Setup Node
uses: actions/setup-node@v3
with:
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Upgrade setup-node to v4 (v3 now blocked on GH runners).

actionlint flags v3 as too old. Move to v4 to unbreak the job.

-    - name: Setup Node
-      uses: actions/setup-node@v3
+    - name: Setup Node
+      uses: actions/setup-node@v4
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Setup Node
uses: actions/setup-node@v3
with:
- name: Setup Node
uses: actions/setup-node@v4
with:
🧰 Tools
🪛 actionlint (1.7.7)

20-20: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents 
In .github/workflows/compressed-diff.yml around lines 19 to 21 the workflow uses
actions/setup-node@v3 which is blocked on GitHub runners; update the action to
actions/setup-node@v4 by changing the version reference so the job uses the v4
release. Ensure there are no breaking input changes in the workflow (keep the
existing with: inputs the same) and run the workflow lint to confirm actionlint
no longer flags the version.

node-version: 14.x
node-version: 18.x
cache: 'npm'
- name: Install Build Tools
run: |
sudo apt-get update
sudo apt-get install -y build-essential
- name: Install Dependencies
run: |
npm ci --legacy-peer-deps
cd pro__premium_only
npm ci --legacy-peer-deps
- uses: preactjs/compressed-size-action@v2
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
Expand Down
Loading