Flamegraph in silver surfer#124
Merged
Merged
Conversation
vladimir-ea
reviewed
Jun 25, 2026
| tracing::debug!("start"); | ||
|
|
||
| // `#[timed]` is inert until a process opts in. | ||
| silver_common::flamegraph_timer::enable_overseer(); |
Collaborator
There was a problem hiding this comment.
lets not use 'overseer' ..
Contributor
Author
There was a problem hiding this comment.
Sure, misnaming sometimes
vladimir-ea
reviewed
Jun 25, 2026
| # — surfer labels the producer's counter slots positionally, so a mismatch | ||
| # mislabels the columns. Extra args pass through as `[BASE_DIR] [APP_NAME]`. | ||
| surfer events="instructions,cycles,l1d-misses,l2-misses,l3-misses" *args='': | ||
| SILVER_PERF_EVENTS="{{events}}" cargo run --release -p silver_surfer --features perf -- {{args}} |
Collaborator
There was a problem hiding this comment.
is there a default for the events?
Contributor
Author
There was a problem hiding this comment.
We have default events const DEFAULT_EVENTS: &str = "instructions,cpu-cycles,branch-misses,cache-misses";, potentially will need to dump to a file which perf events we use to correctly display in surfer instead of manual env var here
vladimir-ea
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.