Remove jclouds dependency by forking the blobstore API#1046
Draft
gaul wants to merge 1 commit into
Draft
Conversation
d6f4542 to
963b7aa
Compare
Copy the jclouds blobstore types we use (BlobStore, Blob, BlobMetadata, MultipartUpload, options, payloads, exceptions) into a new org.gaul.s3proxy.blobstore package, strip Guice dependency injection, and replace ContextBuilder with a direct BlobStores factory. Drop the legacy jclouds-only providers (filesystem, transient, aws-s3, azureblob, google-cloud-storage); only the SDK-backed providers remain (filesystem-nio2, transient-nio2, aws-s3-sdk, azureblob-sdk, google-cloud-storage-sdk). The forked types are modernized rather than preserved verbatim: BlobMetadata, ContainerMetadata, MultipartUpload, MultipartPart, ContentMetadata, HttpResponse, the *Options classes, and Credentials are records; StorageMetadata is a sealed interface; Blob and Payload are immutable with Builder factories (Blob.Builder is nested and takes the name at construction). Several redundant abstractions are dropped along the way: BlobStore.blobBuilder, the Multimap-based allHeaders (collapsed to a single Content-Range field), updateMetadata Consumer overloads (replaced by direct setters), and Payload.release() (no callers). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the jclouds blobstore types we use (BlobStore, Blob, BlobMetadata,
MultipartUpload, options, payloads, exceptions) into a new
org.gaul.s3proxy.blobstore package, strip Guice dependency injection,
and replace ContextBuilder with a direct BlobStores factory. Drop the
legacy jclouds-only providers (filesystem, transient, aws-s3, azureblob,
google-cloud-storage); only the SDK-backed providers remain
(filesystem-nio2, transient-nio2, aws-s3-sdk, azureblob-sdk,
google-cloud-storage-sdk).
The forked types are modernized rather than preserved verbatim:
BlobMetadata, ContainerMetadata, MultipartUpload, MultipartPart,
ContentMetadata, HttpResponse, the *Options classes, and Credentials
are records; StorageMetadata is a sealed interface; Blob and Payload
are immutable with Builder factories (Blob.Builder is nested and takes
the name at construction). Several redundant abstractions are dropped
along the way: BlobStore.blobBuilder, the Multimap-based allHeaders
(collapsed to a single Content-Range field), updateMetadata Consumer
overloads (replaced by direct setters), and Payload.release() (no
callers).