This PR executes several critical robustness improvements and bug fixes across the ModelGenerator repository, resolving known technical debt and improving CLI safety.#30
Open
psMDHamdan wants to merge 2 commits into
Conversation
- Centralized process_batch() across sequence backbone classes - Resolved configure_model() re-initialization bugs via @once_only - Fixed JSONArgparse YAML config conflicts with instantiate linking - Migrated WandB sweep documentation to MkDocs structure - Added initial pytest suite per module
psMDHamdan
changed the title
ModelGenerator repository, resolving known technical debt and improving CLI safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Summary
This PR executes several critical robustness improvements and bug fixes across the
ModelGeneratorrepository, resolving known technical debt and improving CLI safety.🛠️ Key Changes
.obs_names_make_unique()via a new utility across data loaders (CellClassificationDataModule,ClockDataModule,SpatialDataGenerator).@once_onlydecorator in rif_task, pif_task, and rna_ss_task.jsonargparseYAML config conflict warnings by routing all dynamic CLI linkages throughapply_on="instantiate"inside main.py.docs/docs/usage/wandb_sweeps.md), and stubbed structural Pytest coverage structures for custom protein & RNA endpoints.✅ Verification
jsonargparseconflict warnings suppressed locally using framework-native mechanisms.