Conversation
brsbl
marked this pull request as ready for review
September 19, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Blocking config reads and error-first rendering hid cached data on slow or failing networks. Thread caches expired after five minutes, and failed page-code downloads escaped to the app-wide error screen.
What changed
Uses existing query caches, subscriptions and error boundaries. Mutations and public APIs are unchanged. Thread caching is in memory; hard reloads need the network. Page-download recovery requires the app shell to have loaded.
How you verified
94d252b6b: cached reads, refresh success/failure, cache misses, retention and page-error recovery.States screenshots cannot establish alone
Before / after screenshots
Merge base 7bbff00 → PR head 94d252b; matching fixtures, routes, interaction states and 390 × 844 @2×. Thread screenshots show requests held after five minutes away; the page-code pair shows a Settings module 503; other pairs show failed background reads. Registry content uses a deterministic fixture. Fresh captures use Chrome for Testing 153.0.8010.52; retained base captures for thread, plugin settings, defaults and both skill views use 153.0.8010.36.
P2 follow-ups
The fresh review covered all 23 changed files at
94d252b6bagainst7bbff004b. These P2s are deferred under the requested review policy:BB-Thread-ID: thr_3mafhqizp2