Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
#3742 changed the unset sidebar organization default from By project to Custom. Existing installations without a persisted choice therefore changed views after upgrading, removing project headings and appearing to lose projects. The legacy browser migration also discarded choices matching the default, and the write path skipped explicitly selecting that default. Inserting a regular By project preference during upgrade would additionally override choices still stored only in a browser.
What changed
This addresses the upgrade/default transition. It does not change project rendering in explicitly selected Custom mode or reconstruct preferences discarded by older versions.
How you verified
pnpm exec turbo run test --filter=@bb/db.pnpm exec turbo run test --filter=@bb/app -- src/lib/ui-preferences src/components/sidebar/ProjectList.modes.test.tsx src/components/sidebar/SidebarHeaderControls.test.tsx.pnpm exec turbo run test --filter=@bb/server -- test/public/public-ui-preferences.test.ts.pnpm exec turbo run typecheck --filter=@bb/app --filter=@bb/server --filter=@bb/db.pnpm exec turbo run lint --filter=@bb/app.