Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Worktree group headers and their member rows did not participate in sidebar dragging, and the header shared an identifier with its first thread. Custom sidebar sections were also applied after environment grouping, so one member's section determined where the whole group appeared. When dragging an expanded group into an empty Threads section, hidden source children could become the final drop target even while the destination preview remained visible, cancelling the move.
What changed
Includes and supersedes #3943, retaining its grouping implementation and regression coverage. Uses existing SDK thread updates and CLI section assignments; no server/daemon wire changes.
How you verified
pnpm exec turbo run test typecheck --filter=@bb/client-core— all 300 tests and typecheck passed on the combined branch.pnpm exec turbo run test --filter=@bb/app -- useSectionThreadDnd ProjectRow.interactions ProjectThreadTree.disclosure sidebarDropPreviewPlacement— all 78 tests passed on the combined branch.pnpm exec turbo run typecheck --filter=@bb/app— passed.pnpm start:worktreeand the source BB CLI to verify expanded/collapsed group moves, moves between sections and back into Threads, nested-child detachment, independent first-member moves, nesting, Escape cancellation, ordinary-thread dragging, and reload persistence.Safari/iOS touch dragging was not tested.