Skip to content

Rename sidebar items in place - #3975

Merged
brsbl merged 23 commits into
mainfrom
bb/plan-design-support-for-renaming-existing-sideba-thr_nnqmgb3wwx
Sep 21, 2026
Merged

brsbl merged 23 commits into
mainfrom
bb/plan-design-support-for-renaming-existing-sideba-thr_nnqmgb3wwx

Conversation

@brsbl

@brsbl brsbl commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Sidebar rename actions used separate dialogs instead of editing the item in place. Returning keyboard focus to a thread row drew a clipped black ring.

What changed

  • Rename threads, projects, custom sections, environments, and machines directly in their sidebar rows.
  • Enter or click-away saves the name, and Escape cancels.
  • Saving and validation states appear in the row, with failed drafts retained for retry.
  • Editors preserve row typography and control alignment.
  • Keyboard-focused thread rows use a background highlight to avoid clipped focus rings.
Bundle impact

The editor loads on demand. The raw boot budget increases by 7 KiB; the compressed cap stays at 419 KiB. Current output is 1695.3 KiB raw and 416.3 KiB Brotli.

How you verified

  • Remote CI passed tests, typecheck, lint, build, bundle budget, and Linux/macOS packaging for 6102e1a47.
  • Chrome for Testing 153.0.8010.52: keyboard entry, long-press, cancellation, validation, retry, and persistence passed at 1440×900 and 390×844.
  • The production AppSidebar story passed section rename and simulated-failure retry.

User authorized merging 6102e1a47 after the current screenshots were presented.

Screenshots

Before: 699f2f1a8 · After: 6102e1a47 · Branch web app · 2× pixel density

State Viewport Before After
Focused thread row Desktop · 1440×900 Before Focused thread row Open before After Focused thread row Open after
Focused thread row Compact · 390×844 Before Focused thread row Open before After Focused thread row Open after
Project rename Desktop · 1440×900 Before Project rename Open before After Project rename Open after
Thread rename Compact · 390×844 Before Thread rename Open before After Thread rename Open after
Environment rename Desktop · 1440×900 Before Environment rename Open before After Environment rename Open after
Duplicate section Desktop · 1440×900 Before Duplicate section Open before After Duplicate section Open after
Machine rename (previously no sidebar editor) Desktop · 1440×900 Before Machine rename (previously no sidebar editor) Open before After Machine rename (previously no sidebar editor) Open after
Saving Desktop · 1440×900 Before Saving Open before After Saving Open after
Save failure Desktop · 1440×900 Before Save failure Open before After Save failure Open after

Interactive story

Production AppSidebar in Ladle, with Planning section rename visible (6102e1a47, 2×).

Section rename in the production sidebar story Open full size

BB-Thread-ID: thr_nnqmgb3wwx

AGENT GENERATED

…t-for-renaming-existing-sideba-thr_nnqmgb3wwx

# Conflicts:
#	apps/app/src/components/sidebar/ProjectList.tsx
#	apps/app/src/components/sidebar/TopLevelSidebarSection.tsx
@brsbl
brsbl merged commit 7c54dbf into main Sep 21, 2026
16 checks passed
@brsbl
brsbl deleted the bb/plan-design-support-for-renaming-existing-sideba-thr_nnqmgb3wwx branch September 21, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant