GUI: Fix login page icon not rendering#90
Open
hwittenborn wants to merge 1 commit into
Open
Conversation
The dialog-question icon doesn't render in GTK4's Adwaita icon theme. Replace with dialog-information-symbolic which is both available and semantically correct for the informational text. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing icon on the GUI login page by replacing a non-existent GTK4/Adwaita icon name with a valid informational icon, ensuring the “credentials are stored in NetworkManager” hint renders correctly.
Changes:
- Replace
dialog-questionwithdialog-information-symbolicfor the login page info icon.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dialog-questionicon name doesn't exist in GTK4's Adwaita icon theme, so the info icon next to "These credentials are stored in NetworkManager" on the login page doesn't renderdialog-information-symbolic, which is both available and semantically correct for informational textTested on Arch Linux (GTK4 + Adwaita icon theme).
Screenshots
Before
After