Skip to content

[codex] Add merged PR issue bookkeeping#6

Merged
EtienneLescot merged 3 commits into
mainfrom
codex/merged-pr-issue-bookkeeping
Jun 19, 2026
Merged

[codex] Add merged PR issue bookkeeping#6
EtienneLescot merged 3 commits into
mainfrom
codex/merged-pr-issue-bookkeeping

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds a GitHub Actions workflow that updates linked issues after a PR is merged into main.

What changed

  • Adds merged-PR issue bookkeeping based on GitHub closingIssuesReferences.
  • Marks linked issues as status: fixed in main and status: pending release.
  • Assigns linked issues to an existing issue milestone, the PR milestone, or Next Release.
  • Updates the PR template and contributing docs so contributors know when to use closing keywords.

Why

Closed issues can otherwise look released even when the desktop installer has not shipped yet. This keeps the issue lifecycle accurate for desktop users while still allowing issues to close when the fix lands in main.

Validation

  • Ran git diff --cached --check.
  • Ran a syntax-only Node check for the embedded actions/github-script JavaScript.

No issue linked; this is repository workflow policy work.

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated contribution guidelines with expanded issue lifecycle documentation, including clarification on issue statuses and release availability.
  • Chores

    • Improved pull request template with a more structured intake form.
    • Added automated workflow for post-merge issue bookkeeping and status management.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@EtienneLescot, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 43 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ef32082-343e-417b-94cc-6f16f75d1bae

📥 Commits

Reviewing files that changed from the base of the PR and between 42ffda6 and 55715c1.

📒 Files selected for processing (8)
  • .github/workflows/merged-pr-bookkeeping.yml
  • electron/electron-env.d.ts
  • electron/ipc/handlers.ts
  • electron/main.ts
  • electron/preload.ts
  • src/components/launch/LaunchWindow.test.tsx
  • src/components/launch/LaunchWindow.tsx
  • tests/e2e/windows-native-checklist.spec.ts
📝 Walkthrough

Walkthrough

Adds a merged-pr-bookkeeping GitHub Actions workflow that triggers on merged PRs to main, then auto-closes referenced issues, applies/removes status labels, assigns a Next Release milestone, and posts a deduplication comment. The PR template gains a Fixes # placeholder and simplified checklists, and CONTRIBUTING.md documents the new issue lifecycle.

Changes

Merged PR Issue Bookkeeping

Layer / File(s) Summary
PR template and contributing docs
.github/pull_request_template.md, CONTRIBUTING.md
PR template is restructured with a Fixes # placeholder, updated type/release/desktop impact checkboxes, and a simplified footer. CONTRIBUTING.md adds an Issue lifecycle section covering label states, Next Release milestone, and closing-keyword conventions.
Workflow trigger, permissions, and helper functions
.github/workflows/merged-pr-bookkeeping.yml
Defines pull_request_target trigger, write-issues/read-contents permissions, and the merged-to-main guard. Implements ensureLabel, ensureMilestone, getClosingIssueNumbers (paginated GraphQL), and hasBookkeepingComment helpers.
Orchestration and per-issue processing
.github/workflows/merged-pr-bookkeeping.yml
Runs setup (labels + milestone), fetches closing issue numbers with early exit on empty result, then for each issue applies status labels, strips in-progress/triage labels, closes the issue as completed, and posts a PR-keyed deduplication comment.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A PR lands, the main branch grows,
The rabbit stamps each issue closed.
Labels swap with scripted grace,
"Fixed in main" now takes its place.
The milestone waits for release day—
Hop hop, the bookkeeping's underway! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description covers the main changes, motivation, and validation, but it does not follow the repository's required template structure with sections like Type of Change, Screenshots/Video, Testing, and Checklist. Align the description with the template by adding the missing sections: Type of Change, Screenshots/Video, and Checklist. Ensure all required template elements are included.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a GitHub Actions workflow for merged PR issue bookkeeping, which aligns with the primary addition of the merged-pr-bookkeeping.yml workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/merged-pr-issue-bookkeeping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EtienneLescot EtienneLescot marked this pull request as ready for review June 19, 2026 08:31

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42ffda6530

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/merged-pr-bookkeeping.yml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/merged-pr-bookkeeping.yml:
- Around line 216-220: The multiline string assigned to the `body` property in
the GitHub Actions workflow is breaking YAML syntax because of unescaped
backticks and template literal syntax within the `script: |` block. Fix this by
properly escaping the backticks in the template literal string (the ones around
main, ${milestoneTitle}, and ${pendingReleaseLabel.name}), or wrap the entire
body string assignment in quotes to ensure the YAML parser treats it as a valid
literal string while preserving the JavaScript template literal functionality.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: efac137f-4db3-4f83-8efb-e82b205dca35

📥 Commits

Reviewing files that changed from the base of the PR and between 1a17f8b and 42ffda6.

📒 Files selected for processing (3)
  • .github/pull_request_template.md
  • .github/workflows/merged-pr-bookkeeping.yml
  • CONTRIBUTING.md

Comment thread .github/workflows/merged-pr-bookkeeping.yml Outdated
@EtienneLescot EtienneLescot merged commit 1668cf4 into main Jun 19, 2026
12 of 13 checks passed
@EtienneLescot EtienneLescot deleted the codex/merged-pr-issue-bookkeeping branch June 19, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant