feat(spans): Infer descriptions via sentry-conventions#6093
Merged
Conversation
This reverts commit 2ccf16a.
loewenheim
force-pushed
the
sebastian/description-conventions
branch
from
a041cdd to
552c867
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
reviewed
Jun 15, 2026
| } | ||
|
|
||
| None | ||
| let op = attributes.get_value(SENTRY__OP)?.as_str()?; |
Member
There was a problem hiding this comment.
This means we cannot infer a description with a missing op, is that enough?
I thought we're gonna have rules which may not require an op to be present.
Contributor
Author
There was a problem hiding this comment.
That is at least not how it works now. The schema in conventions specifies that each rule needs to apply to a nonempty list of ops. But we can change that if we don't want to assume the presence of an op for V2 spans.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f6db5bf. Configure here.
Dav1dde
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements description inference based on
sentry-conventions, paralleling the existing name inference logic. The conventions logic wholly subsumes thedbandhttpspecial cases that were previously implemented in this repo.Closes INGEST-956.