Skip to content

ref(tracemetrics): Add integration for inbound for tracemetrics#6109

Merged
k-fish merged 2 commits into
masterfrom
ref/tracemetrics/add-integration-test
Jun 22, 2026
Merged

ref(tracemetrics): Add integration for inbound for tracemetrics#6109
k-fish merged 2 commits into
masterfrom
ref/tracemetrics/add-integration-test

Conversation

@k-fish

@k-fish k-fish commented Jun 18, 2026

Copy link
Copy Markdown
Member

Forgot to do this during relay work for tracemetrics, had a ticket so came back to finish this off.

Follows from test_filters_are_applied_to_logs in the logs integration tests, not sure if we care about testing metadata on inbound so left it out of the parameterize.

Closes LOGS-463

Forgot to do this during relay work for tracemetrics, had a ticket so came back to finish this off.

Closes LOGS-463
@k-fish k-fish requested a review from a team as a code owner June 18, 2026 20:02
@linear-code

linear-code Bot commented Jun 18, 2026

Copy link
Copy Markdown

LOGS-463

@loewenheim loewenheim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! The title should be something like test(tracemetric): Add integration test for inbound for tracemetrics though.

@Dav1dde Dav1dde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Comment thread tests/integration/test_trace_metrics.py Outdated
Co-authored-by: David Herberth <david.herberth@sentry.io>
@k-fish k-fish added this pull request to the merge queue Jun 22, 2026
Merged via the queue into master with commit 2950415 Jun 22, 2026
33 checks passed
@k-fish k-fish deleted the ref/tracemetrics/add-integration-test branch June 22, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants