[SYCL] rename GGML_SYCL_SUPPORT_LEVEL_ZERO#24719
Open
arthw wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
documentation
…PI, and GGML_SYCL_ENABLE_LEVEL_ZERO to GGML_SYCL_USE_LEVEL_ZERO_API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename following environment variables in code and doc:
GGML_SYCL_SUPPORT_LEVEL_ZERO to GGML_SYCL_SUPPORT_LEVEL_ZERO_API
GGML_SYCL_ENABLE_LEVEL_ZERO to GGML_SYCL_USE_LEVEL_ZERO_API
The original names make the user misunderstand the function in real case:
User think GGML_SYCL_SUPPORT_LEVEL_ZERO = OFF or GGML_SYCL_ENABLE_LEVEL_ZERO = OFF mean SYCL can't run on Level Zero running time, and switch to OpenCL running time.
In fact, they show SYCL backend use level zero API or SYCL API for memory allocation. Have nothing with level zero running time.
Test the all UT cases locally.