Add optional size limits for ignore files - #32
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Adds optional per-file size limits for ignore files while preserving unlimited behavior for existing APIs.
Changes:
- Adds
MaxIgnoreFileSizeoptions and bounded reads. - Integrates limits into constructors, nested discovery, and walks.
- Documents behavior and adds coverage for limits and errors.
File summaries
| File | Summary |
|---|---|
README.md |
Documents size-limit APIs and behavior. |
options.go |
Implements options and bounded reads. |
options_test.go |
Tests limits, diagnostics, and walks. |
gitignore.go |
Integrates limits across loading and traversal. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Options.MaxIgnoreFileSizethrough newWithOptionsconstructors and walk functions. Existing entrypoints remain unlimited, andAddPatternsis unaffected.The limit applies to global excludes, repository excludes, and nested ignore files. Bounded reads prevent files that grow after the size check from exceeding the limit. Constructors skip oversized files and record them in
Errors(); limited walks stop with anIgnoreFileSizeErrorcontaining the path and limit.Fixes #29.