Skip to content

[Deps] Put clap behind an optional cli feature #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kageiit merged 1 commit into from
Aug 26, 2026
Merged

[Deps] Put clap behind an optional cli feature #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ async-stream = "0.3"
mime_guess = "2"
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
config = "0.15"
clap = { version = "4", features = ["derive"] }
# Optional: the two binaries below are the only clap users, and a library consumer that
# never builds them was compiling clap plus its 12-crate subtree for nothing.
clap = { version = "4", features = ["derive"], optional = true }
reqwest = { version = "0.12", features = ["json"] }
reqwest-eventsource = "0.6"
mime = "0.3"
Expand All @@ -38,13 +40,21 @@ tracing-core = "0.1"
async-recursion = "1"
http = "1.1"

# Off by default so `mcp_rs` as a dependency carries no CLI parser. `required-features`
# makes cargo skip the binaries rather than fail when it is off, so `cargo build` on a
# checkout still succeeds and `--all-features` (what CI runs) still builds and lints them.
[features]
cli = ["dep:clap"]

[[bin]]
name = "server"
path = "bin/server.rs"
required-features = ["cli"]

[[bin]]
name = "client"
path = "bin/client.rs"
required-features = ["cli"]

[lib]
name = "mcp_rs"
Expand Down
Loading