Add GitHub CLI devcontainer feature and trim quality-checks skill - #116
Open
GeekTrainer wants to merge 3 commits into
Open
GeekTrainer wants to merge 3 commits into
GeekTrainer wants to merge 3 commits into
Conversation
Add the official GitHub CLI devcontainer feature so gh is available in Codespaces. Remove Playwright/E2E content from the quality-checks skill so it covers only unit tests, lint, and type check. Delete the now-unused .mcp.json (the .vscode/mcp.json config remains). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Delete the accessibility, pr-readiness, and seo custom agent definitions from .github/agents/. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update E2E guidance callers and include type checking in the skill description.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates development tooling and documentation by adding GitHub CLI support, narrowing the quality-checks skill, and removing unused MCP configuration.
Changes:
- Adds the GitHub CLI devcontainer feature.
- Removes Playwright/E2E guidance from
quality-checks. - Deletes the unused root
.mcp.json.
| File | Summary |
|---|---|
.mcp.json |
Removes unused root MCP configuration. |
.github/skills/quality-checks/SKILL.md |
Narrows documented checks but leaves E2E instructions inconsistent and omits type checking from its description. |
.devcontainer/devcontainer.json |
Adds GitHub CLI support. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The quality-checks skill no longer covers the Playwright E2E suite, so update copilot-instructions.md and playwright.instructions.md to run E2E directly via npm run test:e2e instead of routing it through the skill. Keeps repo guidance consistent with the trimmed skill. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bundles a few small dev-environment cleanups. Adds the GitHub CLI to the devcontainer so
ghis available in Codespaces, trims thequality-checksskill down to the checks it actually still covers, removes an unused MCP config file, and removes the repo's custom agent definitions.Related Issue
N/A
Type of Change
Changes Made
ghcr.io/devcontainers/features/github-cli:1feature (latest, v1.1.2) to.devcontainer/devcontainer.jsonusing default options.quality-checksskill so it now covers only unit tests (Vitest), lint (ESLint), and type check. Updated the description, quick reference, debugging sections, verification note, and pre-commit checklist accordingly..mcp.json(the.vscode/mcp.jsonconfig remains in place)..github/agents/(accessibility, pr-readiness, seo).Testing
Config and documentation only; no application code changed.
Data Layer Changes
npm run test:unit- all tests passnpm run db:generate) for any schema changeFrontend Changes
npm run test:e2e- all tests passdata-testidattributes to interactive elementsnpm run build)N/A - no data-layer or frontend code changes.
Checklist
Additional Notes
The
quality-checksskill edit only removes E2E/Playwright references from the skill itself; the actual Playwright E2E suite (e2e-tests/, thetest:e2escript, config) is unchanged in this PR. Worth a careful read of the SKILL.md diff to confirm no non-Playwright guidance was lost.