Fail fast with a descriptive error when an updater image is missing from the catalog - #1781
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
v-thavaahariharangit
September 18, 2026 12:54
View session
v-thavaahariharangit
marked this pull request as ready for review
September 18, 2026 12:55
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly handles the missing catalog entry and includes appropriate regression coverage.
Pull request overview
Adds clear handling when no updater image exists for a package manager.
Changes:
- Fails early with a descriptive image error.
- Adds regression coverage.
- Regenerates the bundled action.
File summaries
| File | Description |
|---|---|
src/main.ts |
Adds the missing-image guard. |
__tests__/main.test.ts |
Tests failure reporting and prevents image pulls. |
dist/main.js |
Updates the bundled runtime. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jakecoffman
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHES release bundles can pin a Dependabot action whose
docker/containers.jsonpredates an ecosystem the backend already accepts (e.g. Conda in GHES 3.21.X). When that happens,updaterImageName()returnsundefined, which reachesvalidImageRepository()'s.startsWith()call and throws an uncaughtTypeError, surfaced only as a genericError fetching updater images.Changes
src/main.ts, immediately after resolvingupdaterImage(fromparams.updaterImageorupdaterImageName(details['package-manager'])), fail the job early with a descriptive error naming the unsupported package manager if no image was resolved, instead of proceeding into the pull/registry-validation path.__tests__/main.test.tscovering a package manager with no catalog entry, asserting the job fails without attempting any image pulls and reports a descriptive error to the Dependabot service.Example
This turns an opaque, uncaught
TypeErrorinto a clear, actionable diagnostic that identifies the affected package manager, without changing behavior for any ecosystem already present in the image catalog.