Conversation
Signed-off-by: Eric Pickard <piceri@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment record creation request to set return_records=false, reducing response payload/bandwidth since the deployment tracker doesn’t use the response body from the create call.
Changes:
- Replace direct
json.Marshal(record)with a helper that injectsreturn_records=falseinto the request body. - Add/extend a request-validation test to assert the new request field is present.
Show a summary per file
| File | Description |
|---|---|
| pkg/deploymentrecord/client.go | Build request JSON with return_records=false when posting a deployment record. |
| pkg/deploymentrecord/client_test.go | Validate the POST body includes return_records:false. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
malancas
approved these changes
Apr 9, 2026
malancas
left a comment
malancas
left a comment
There was a problem hiding this comment.
The Copilot suggestions also make sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes sets return_records to false when creating deployment records. This will reduce bandwidth as deployment tracker does not use the response body content from creating deployment records.
https://docs.github.com/en/rest/orgs/artifact-metadata?apiVersion=2026-03-10#create-an-artifact-deployment-record