fix: handle music video cover URL template in _get_raw_cover_url#321
Open
jelius-sama wants to merge 1 commit into
Open
fix: handle music video cover URL template in _get_raw_cover_url#321jelius-sama wants to merge 1 commit into
jelius-sama wants to merge 1 commit into
Conversation
Signed-off-by: Jelius Basumatary <personal@jelius.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Music video covers were failing with a 400 when using
--cover-format raw. Turns out_get_raw_cover_urlonly stripped/{w}x{h}bb.jpgbut music video artwork URLs end withmv.jpginstead ofbb.jpg.I was getting this kind of error:
Just added
mvas an alternative in the regex.P.S. I forget to create a feature branch on the previous PR, since I'm trying to add word-by-word synced lyrics download support I thought I'd clean up the mess I made. Sorry.