Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in string decode hooks accept any source whose reflected kind is string, but asserting
data.(string)panics for defined types such astype ConfigValue string. Read the reflected string value after the existing kind checks so these inputs follow the same parsers and error paths as ordinary strings.Tests exercise named and ordinary strings across the built-in conversions, plus full decoding into named-string slices and IP networks.
go test -race -shuffle=on ./...passes. The changed code passes lint; the full lint run with v2.13.2 reports three existing govet findings in unchangedmapstructure.go.