Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
DecodeNil: true, composingStringToTimeDurationHookFunc()followed byRecursiveStructToMapHookFunc()panics when decoding a map containing a nil value. The first hook passes nil through,ComposeDecodeHookFuncturns it into an invalidreflect.Value, and the recursive hook callsInterface()on that value.Use the existing
safeInterfacehelper for the recursive hook's non-struct passthrough. The regression test exercises standalone and composed hooks, checks that the nil entry is preserved, and checks that nested structs still become maps.Validation on Go 1.27.1:
reflect: call of reflect.Value.Interface on zero Valuebefore the fix and passes afterward.go test -race -v -shuffle=on ./...passed.go vet ./...passed.golangci-lint fmt --diffandgit diff --checkpassed.golangci-lint run --new-from-rev=origin/main --timeout=2mreported zero issues. The full local lint run with v2.13.2 reports threegovetfindings aboutreflect.Ptrin unchangedmapstructure.go; the same three findings reproduce in a clean worktree of upstream main (52aa5c6).