decode: record Metadata.Keys for struct-to-map fields - #205
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
decodeMapFromStruct copied exported fields into the result map without recording them, so DecodeMetadata left Keys empty. Fixes go-viper#127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decodeMapFromStruct copied exported fields into the result map without recording them, so DecodeMetadata left Keys empty when decoding a struct into a map.
The map-to-struct path already records Keys via decode(). This records the same metadata for the default (non-struct) struct-to-map assignment, and for remain-tag keys that are copied through.
Hidden (
-) and unexported fields stay omitted, matching the decoded map.Fixes #127