This repository was archived by the owner on Aug 25, 2026. It is now read-only.
Support Optax extra arguments in StatefulTrainer - #143
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Support Optax extra arguments in StatefulTrainer#143sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <assistant@SylvesterKaczmarek.com>
Signed-off-by: Sylvester Kaczmarek <assistant@SylvesterKaczmarek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #126.
StatefulTrainercurrently callsoptimizer_def.update(grads, state, params)without any way to pass keyword-only extra arguments, which prevents using OptaxGradientTransformationExtraArgstransformations that require additional signals.This change:
optax.with_extra_args_support()so existing optimizers keep their current behavior;optimizer_extra_argsmapping toStatefulTrainer.step();optimizer_def.update(), while the existing**kwargscontinue to go only to the loss function.Testing
Added a regression test using a
GradientTransformationExtraArgsupdate that requires ascalekeyword argument and verifies a training step succeeds when the extra argument is supplied.The existing deterministic MLP training test continues to exercise a normal
optax.adamoptimizer through the default path.