Skip to content

refactor: making the McpAsyncToolset constructor protected for subclassing #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

refactor: making the McpAsyncToolset constructor protected for subclassing #1135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/java/com/google/adk/tools/mcp/McpAsyncToolset.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,13 @@ public McpAsyncToolset build() {
}

/**
* Initializes the McpAsyncToolset with SSE server parameters.
* Initializes the McpAsyncToolset with a provided McpSessionManager.
*
* @param connectionParams The SSE connection parameters to the MCP server.
* @param mcpSessionManager The session manager for MCP connections.
* @param objectMapper An ObjectMapper instance for parsing schemas.
* @param toolFilter Either a ToolPredicate or a List of tool names.
*/
McpAsyncToolset(
protected McpAsyncToolset(
McpSessionManager mcpSessionManager, ObjectMapper objectMapper, @Nullable Object toolFilter) {
Objects.requireNonNull(mcpSessionManager);
Objects.requireNonNull(objectMapper);
Expand Down