feat(cli): deploy agent engine to Artifact Registry instead of GCR (Agent Engine Deployment Artifact registry fix part 2)#441
Open
AmaadMartin wants to merge 6 commits into
Conversation
added 5 commits
June 16, 2026 12:37
…ONS instead of editing workflow
kalenkevich
approved these changes
Jun 16, 2026
…into feat/use-artifact-registry-for-deployment
9 tasks
kalenkevich
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide https://google.github.io/adk-docs/contributing-guide/ before creating a pull request.
Link to Issue or Description of Change
• Closes: #none
• Related: #none
Problem:
gcr.iocontainer registry for Reasoning Engine builds.gcloud builds submitto return exit code 1 even when the build completes successfully.Solution:
${region}-docker.pkg.dev/${project}/${repository}/...).--repositoryoption, failing early with explicit regionalgcloudcreation instructions if omitted.gs://${project}_cloudbuild/logs) via the--gcs-log-dirflag to bypass VPC-SC restrictions.Testing Plan
Unit Tests:
Summary of passed test results:
✓ |unit:dev| dev/test/cli/cli_deploy_agent_engine_test.ts (13 tests) 69ms
✓ deployToAgentEngine > should deploy successfully with explicit options 18ms
✓ deployToAgentEngine > should deploy successfully with all optional parameters 3ms
✓ deployToAgentEngine > should resolve default project and region from gcloud if not provided 4ms
✓ deployToAgentEngine > should deploy successfully with custom repository name 4ms
✓ deployToAgentEngine > should throw error if region resolution fails (unset) 4ms
✓ deployToAgentEngine > should deploy successfully when agentPath is a file 3ms
✓ deployToAgentEngine > should deploy successfully without explicit displayName 2ms
✓ deployToAgentEngine > should throw error if project resolution fails (unset) 2ms
✓ deployToAgentEngine > should clean up existing temp folder before deploying 2ms
✓ deployToAgentEngine > should throw error if required npm packages are missing in package.json 4ms
✓ deployToAgentEngine > should handle spawn failures during build 2ms
✓ deployToAgentEngine > should throw error if Reasoning Engine creation operation times out 9ms
Files tested:
• dev/test/cli/cli_deploy_agent_engine_test.ts
Manual End-to-End (E2E) Tests:
Successfully ran:
ADK_DEV_MODE=true node dev/dist/esm/cli_entrypoint.js deploy agent_engine /tmp/observability-e2e-run/real_agent.ts
--project amaadmartin-claw-15058
--region us-central1
--repository agent-engine-repo
--temp_folder /tmp/observability-e2e-run/temp-adk-deploy
--port 8080
Which built, pushed, created the Reasoning Engine, and responded to querying successfully under VPC-SC.
Checklist
Additional context
This PR is stacked on top of #440.