fix: harden builder upload YAML validation#5344
Open
TristanInSec wants to merge 1 commit intogoogle:mainfrom
Open
fix: harden builder upload YAML validation#5344TristanInSec wants to merge 1 commit intogoogle:mainfrom
TristanInSec wants to merge 1 commit intogoogle:mainfrom
Conversation
Reject fully-qualified (dotted) Python references in builder YAML uploads for name, agent_class, and code fields. Simple (non-dotted) names continue to work for ADK built-in tools and agent classes. Adds 6 tests covering rejection and allowlisting behavior.
Collaborator
|
Response from ADK Triaging Agent Hello @TristanInSec, thank you for creating this PR! To help us track and contextualize this important security fix, could you please create a GitHub issue that describes the vulnerability and link it to this PR? This will help us maintain a clear record of the issue and its resolution. Thanks! |
Author
|
Created #5347. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name,agent_class, andcodefieldsTest plan
os.system)google_search)LlmAgent)