Skip to content

Add apt/pypi/npm mirror supports#251

Closed
wuhuizuo wants to merge 1 commit into
google:masterfrom
wuhuizuo:feature/support-mirror-apt_npm_pypi
Closed

Add apt/pypi/npm mirror supports#251
wuhuizuo wants to merge 1 commit into
google:masterfrom
wuhuizuo:feature/support-mirror-apt_npm_pypi

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

This request enable docker building in env that unable access to internet.
support custom mirrors when docker image building:

  • apt source: replace /etc/apt/source.list with sed when given.
  • npm registry: execute npm config set registry <custom_registry> when given.
  • pip index: add -i ${pip_index} args to pip install when given.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

@googlebot I fixed it.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

@googlebot I fixed it.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@wuhuizuo wuhuizuo force-pushed the feature/support-mirror-apt_npm_pypi branch from e9b5f3e to 98392b5 Compare April 27, 2021 05:57
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

@googlebot I fixed it.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jpcottin
Copy link
Copy Markdown
Collaborator

Hi @wuhuizuo — thank you for this PR, and apologies for the very long delay
before responding.

The patch can't apply cleanly anymore:

  1. The --aptmirror plumbing flows through EmulatorContainer.__init__, whose
    signature has changed since 2021 (most recently in PR Surface API 33-37 and 16 KB-page system images #397). The mirror
    argument would need to be re-threaded.
  2. js/jwt-provider/Dockerfile, one of the files modified here, was removed
    in commit 174ab2d ("Use Firebase for authentication."). That subsystem no
    longer exists.
  3. The create_web_container.sh portion partially overlaps with PR emu/containers: return emulator ID if image is not available locally #390
    (merged), which already migrated that script to docker compose v2.

Closing rather than asking for a rebase.

Thanks again for the contribution and for raising the use case.

@jpcottin jpcottin closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants