Fix two typos in emu/containers/docker_container.py#399
Merged
Conversation
- launch() docstring: "abd" -> "adb"; also include the port number for parity with the existing "gRPC on port 8554" half of the sentence. - available() log message: "avaliable" -> "available". These were originally proposed by @binderjens in google#350; that PR also did README updates that have since been done by google#390. Co-Authored-By: Jens Binder <binderjens@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two trivial typo fixes in
emu/containers/docker_container.py:launch()docstring:abd→adb(also include the port number for parity with thegRPC on port 8554half of the sentence).available()log message:avaliable→available.Originally proposed by @binderjens in #350. The README half of that PR was already addressed by #390 (danishprakash), so cherry-picking just the two typos here. Closing #350 once this lands.
Test plan
tests/(excluding e2e) still pass.