Conversation
Use the explicit atespace for apply and reject conflicting manifest values.
Contributor
Author
|
Adding the reproduction steps and before/after output. I ran both versions against fresh local AX gRPC servers using the in-memory store, with Save this as apiVersion: ax.io/v1alpha1
kind: Workspace
metadata:
name: atespace-example
spec: {}Before ( After ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a manifest that omits
metadata.atespace,ax apply -a team-a -f workspace.yamlsucceeds but creates the resource indefault. The CLI parses the flag but doesn't pass it torunApply.Pass the explicit atespace through to apply and use it before looking up or submitting Tasks, Workspaces, and Models. When no flag is given, the manifest's atespace is preserved and missing values still default to
default.This also rejects a resource when its manifest atespace differs from an explicitly supplied flag, including
-a default. Would you prefer a different precedence rule for that case?Added CLI integration tests covering resource placement, repeated apply, and conflicting atespaces, and documented the behavior. Verified with
make test,make build, andgo mod tidywith no module changes.Refs #414