Implement Rust-side reconstruction of the nested IR to FlatIR.#1235
Open
copybara-service[bot] wants to merge 1 commit into
Open
Implement Rust-side reconstruction of the nested IR to FlatIR.#1235copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_933733681
branch
from
680644e to
323f966
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_933733681
branch
3 times, most recently
from
ddfd648 to
be40694
Compare
This change does not yet modify consumers in generate_bindings to use the realized children's items. Rather we derive the children_item_ids from the items passed by the frontend (if the nested_IR flag is enabled) to be consistent with the flat IR branch. Specifically, this change: - Implements `make_ir_from_tree` in `ir.rs` to reconstruct the declaration tree on the Rust side from `top_level_items`, and populate a lookup cache of itemId to items. - Ensures nested items are discoverable: `db::find_untyped_decl` looks up items in the reconstructed tree cache instead of `flat_ir.items`. - Propagates changes to IR structure and db to the relevant bindings generation logic ie. `generate_struct_and_union.rs` PiperOrigin-RevId: 933733681
copybara-service
Bot
force-pushed
the
test_933733681
branch
from
be40694 to
e929998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Rust-side reconstruction of the nested IR to FlatIR.
This change does not yet modify consumers in generate_bindings to use the realized children's items. Rather we derive the children_item_ids from the items passed by the frontend (if the nested_IR flag is enabled) to be consistent with the flat IR branch.
Specifically, this change:
make_ir_from_treeinir.rsto reconstruct the declaration tree on the Rust side fromtop_level_items, and populate a lookup cache of itemId to items.db::find_untyped_decllooks up items in the reconstructed tree cache instead offlat_ir.items.generate_struct_and_union.rs