Add lazy message evaluation to ProcessorErrors.checkState#5169
Merged
Conversation
This change introduces new overloads of `ProcessorErrors.checkState` that accept a `Supplier<String>` for the error message. This allows the error message to be constructed only when the check fails, avoiding unnecessary work when the condition is true. Existing usages in `AndroidEntryPointMetadata` and `Processors` are updated to use these new overloads for `XAnnotation.toStableString()`, as these can be expensive. RELNOTES=N/A PiperOrigin-RevId: 916143466
copybara-service
Bot
force-pushed
the
test_916102272
branch
from
519406b to
2a5862a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lazy message evaluation to ProcessorErrors.checkState
This change introduces new overloads of
ProcessorErrors.checkStatethat accept aSupplier<String>for the error message. This allows the error message to be constructed only when the check fails, avoiding unnecessary work when the condition is true.Existing usages in
AndroidEntryPointMetadataandProcessorsare updated to use these new overloads forXAnnotation.toStableString(), as these can be expensive.RELNOTES=N/A