Refactor: Optimize nearestSuperClassMethod in Hilt AndroidEntryPoint processor#5170
Merged
Conversation
…processor The previous implementation used `getAllMethods()` and then filtered, which can be inefficient as `getAllMethods()` resolves all methods in the hierarchy. The new approach traverses up the superclass hierarchy, checking `getDeclaredMethods()` at each level, and returns as soon as the matching method is found. This is more efficient as it stops at the nearest override. RELNOTES=N/A PiperOrigin-RevId: 916183096
copybara-service
Bot
force-pushed
the
test_916115441
branch
from
66b08f2 to
d0cadc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Optimize nearestSuperClassMethod in Hilt AndroidEntryPoint processor
The previous implementation used
getAllMethods()and then filtered, which can be inefficient asgetAllMethods()resolves all methods in the hierarchy. The new approach traverses up the superclass hierarchy, checkinggetDeclaredMethods()at each level, and returns as soon as the matching method is found. This is more efficient as it stops at the nearest override.RELNOTES=N/A