Refactor MethodSignature to delay expensive calculations.#5171
Open
copybara-service[bot] wants to merge 1 commit into
Open
Refactor MethodSignature to delay expensive calculations.#5171copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Calculating `XMethodElement.parameters()` can be expensive because it triggers KSP's Analysis API to resolve parameter types. This CL restructures `MethodSignature` to delay calling `XMethodElement.parameters()` until it's actually needed. The main changes are: * `hashCode()` now only looks at the method name. For Set and Map insertions, `equals()` will only be called when there's a name collision. * `equals()` short-circuits if the `name()` is not equal, so it avoids computing the lazy `parameters()` in most cases. RELNOTES=N/A PiperOrigin-RevId: 916099675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor MethodSignature to delay expensive calculations.
Calculating
XMethodElement.parameters()can be expensive because it triggers KSP's Analysis API to resolve parameter types. This CL restructuresMethodSignatureto delay callingXMethodElement.parameters()until it's actually needed.The main changes are:
hashCode()now only looks at the method name. For Set and Map insertions,equals()will only be called when there's a name collision.equals()short-circuits if thename()is not equal, so it avoids computing the lazyparameters()in most cases.RELNOTES=N/A