Fix setDepthClipMode breaking Metal API validation when running under an iOS simulator#66
Open
meuter wants to merge 1 commit into
Open
Fix setDepthClipMode breaking Metal API validation when running under an iOS simulator#66meuter wants to merge 1 commit into
meuter wants to merge 1 commit into
Conversation
… an iOS simulator Closes issue #457771794. All credits to the original author in https://issues.chromium.org/issues/457771794
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running dawn on an iOS simulator, the initialization fails with the error message "Depth Clip Mode is not supported on this device". The iOS simulator apparently does not support depth clip mode. This patch avoid setting it if not strictly necessary.
Closes issue #457771794. All credits to the original author in https://issues.chromium.org/issues/457771794.
Changes
The change is in
src/dawn/native/metal/CommandBufferMTL.mmand simply avoids calling[encoder setDepthClipMode:MTLDepthClipModeClamp]if the pipeline does not call for it.