Skip to content

fix(util/semver): reject empty constraint for Maven #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuixq merged 2 commits into from
May 29, 2026
+2 −1
Merged

fix(util/semver): reject empty constraint for Maven #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8836da8
fix(util/semver): handle empty constraint for Maven
cuixq May 29, 2026
793e95b
nit
cuixq May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/semver/constraint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (sys System) ParseConstraint(str string) (retC *Constraint, retErr error) {
// creating the empty set, which means the opposite.
lexStr := str
if lexStr == "" {
if sys == NuGet {
if sys == NuGet || sys == Maven {
return nil, fmt.Errorf("invalid empty constraint")
}
lexStr = ">=0.0.0"
Expand Down
1 change: 1 addition & 0 deletions util/semver/maven_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ func TestMavenCanon(t *testing.T) {
}

var mavenConstraintErrorTests = []constraintErrorTest{
{"", "invalid empty constraint"},
{"[", "expected comma or closing bracket in `[`"},
{"()", "hard requirement must be closed on both ends in `()`"},
{")", "unexpected rbracket in `)`"},
Expand Down
Loading